Re: [Xen-devel] [PATCH v2 1/3] xen/arm: Add ThunderX platform support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-02-18 at 12:38 +0000, Julien Grall wrote:
> > +    uint64_t addr, size;

Please use paddr_t and PRIpaddr etc.

> > +    res = map_mmio_regions(d,
> > +                           paddr_to_pfn(addr & PAGE_MASK),
> > +                           DIV_ROUND_UP(size, PAGE_SIZE),
> > +                           paddr_to_pfn(addr & PAGE_MASK));
> 
> OOI, why this region is not described in the DT? Is it a PCI device?

I'm curious too.

> > +    if ( res )
> > +    {
> > +         printk(XENLOG_ERR "Unable to map to dom%d region"
> 
> It would be more clear to specify the name of the region i.e "GSER region"

Agreed.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel