Re: [Xen-devel] [PATCH] tools/hotplug: Don't ever kill xenstored

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Feb 23, 2015 at 05:01:19PM +0000, Andrew Cooper wrote:
> On 23/02/15 16:19, Wei Liu wrote:
> > On Mon, Feb 23, 2015 at 09:18:49AM +0000, Ross Lagerwall wrote:
> >> Don't kill xenstored as part of the usual service shutdown process to
> >> prevent hangs on shutdown where the kernel tries to unplug a VIF
> >> after xenstored has exited.
> >>
> >> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > Do you run xendomains service? Aren't all guests shutdown by that
> > service? And according to the dependency configuration, xenstored should
> > not shutdown before xendomains is done?
> 
> We do not run the xendomains service.  (It also doesn't necessarily shut
> all domains down.)
> 
> In an ideal case with all guests cooperating, they are all shut down by
> this point.
> 
> However in the uncooperative case, malicious or crashed guests, or dom0
> configuration errors must not be able to block shutdown/reboot of dom0.
> 
> Xenstored has no state to sync to disk, and never used to be killed in
> the sysvinit case; observe the warning in xencommons.  Our testing has
> shown regressions caused by the change in behaviour between sysvinit and
> systemd when it comes to killing xenstored.
> 

I think the above reasoning should end up in the commit message.

Wei.

> ~Andrew
> 
> >
> > Wei.
> >
> >> ---
> >>  tools/hotplug/Linux/systemd/xenstored.service.in | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in 
> >> b/tools/hotplug/Linux/systemd/xenstored.service.in
> >> index 0f0ac58..a5f836b 100644
> >> --- a/tools/hotplug/Linux/systemd/xenstored.service.in
> >> +++ b/tools/hotplug/Linux/systemd/xenstored.service.in
> >> @@ -8,6 +8,7 @@ ConditionPathExists=/proc/xen/capabilities
> >>  
> >>  [Service]
> >>  Type=notify
> >> +KillMode=none
> >>  Environment=XENSTORED_ARGS=
> >>  Environment=XENSTORED=@XENSTORED@
> >>  EnvironmentFile=-@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons
> >> -- 
> >> 2.1.0
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel