Re: [Xen-devel] [PATCH] xen: Minor modifications to platform.h to make it C++-friendly

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 02/23/2015 12:54 PM, Jan Beulich wrote:
>>>> @@ -152,24 +159,24 @@ struct xenpf_efi_runtime_call {
>>>>      xen_ulong_t status;
>>>>      union {
>>>>  #define XEN_EFI_GET_TIME_SET_CLEARS_NS 0x00000001
>>>> +        struct xenpf_efi_time {
>>>> +            uint16_t year;
>>>> +            uint8_t month;
>>>> +            uint8_t day;
>>>> +            uint8_t hour;
>>>> +            uint8_t min;
>>>> +            uint8_t sec;
>>>> +            uint32_t ns;
>>>> +            int16_t tz;
>>>> +            uint8_t daylight;
>>>> +        } set_time;
>>>> +
> 
> ... this should be moved out to file scope too, both for consistency
> and to avoid an eventual further adjustment going forward. Otoh
> I'm not convinced we need the headers to be C++ ready (nor am
> I convinced that there aren't any other obstacles preventing their
> unmodified use in C++). Co-maintainers, what do you think?

You're right, it's always better to be consistent. Will do.

As for the headers being C++ ready, there's already the precedent of at
least my previous patch "xenctrl: Make the headers C++ friendly":

http://www.gossamer-threads.com/lists/xen/devel/337788

where it turned out that there's at least one other serious user of Xen
with C++, Don Slutz.

I do understand and respect the fact that C++ is not a xen-devel target,
but I also believe that there are a very small number of changes that
could enlarge the Xen user base to include C++ developers, and that it
can be done in completely painless manner for all involved.


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel