Re: [Xen-devel] [PATCH v2] xen: arm64: more useful logging on bad trap.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-02-19 at 10:22 +0000, Ian Campbell wrote:
> > >>> +    printk("Bad mode in %s handler detected", handler[reason]);
> > >>> +    printk("ESR=0x%08"PRIx32":  EC=%"PRIx32", IL=%"PRIx32", 
> > >>> ISS=%"PRIx32"\n",
> > >>> +           hsr.bits, hsr.ec, hsr.len, hsr.iss);
> > >> This would be better as a single printk() call, otherwise a different
> > >> cpu issuing a printk() could interleave in the middle of the line.
> > >>
> > >> Also, you appear to have dropped the space between "detected" and "ESR"
> > > That's because I forgot to add the \n to the end of the first printk
> > > (the intention was to make the log line <80 columns by splitting it into
> > > two lines). Having fixed that I think your first comment then becomes
> > > irrelevant? Or is there some benefit to printk("foo\nbar\n")?
> > 
> > Not completely irrelevant, but certainly far less problematic, and
> > something I wouldn't worry about.
> 
> Thanks, I think I'll just add the \n on commit

Which I've now done. thanks all.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel