Re: [Xen-devel] [PATCH RFC 3/5] pvh: add rwmem_ranges to keep mapped special regions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.02.15 at 19:52, <elena.ufimtseva@xxxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/hvm/iommu.h
> +++ b/xen/include/asm-x86/hvm/iommu.h
> @@ -2,6 +2,7 @@
>  #define __ASM_X86_HVM_IOMMU_H__
>  
>  #include <xen/errno.h>
> +#include <xen/iommu.h>

Why?

> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -191,4 +191,9 @@ DECLARE_PER_CPU(bool_t, iommu_dont_flush_iotlb);
>  extern struct spinlock iommu_pt_cleanup_lock;
>  extern struct page_list_head iommu_pt_cleanup_list;
>  
> +struct rwmem_range {
> +    struct list_head list;
> +    u64 start, end;
> +};

Without this being used anywhere you leave us to guess what the
fields are for. I think patches 2, 3, and at least 4 are unhelpful to
be split apart.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel