Re: [Xen-devel] [PATCH OSSTEST 02/12] Increase boot timer to accomodate to nest test

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Hu, Robert writes ("RE: [PATCH OSSTEST 02/12] Increase boot timer to accomodate 
to nest test"):
> > Robert Ho writes ("[PATCH OSSTEST 02/12] Increase boot timer to accomodate
> > to nest test"):
> > > In nested test case, guest boot will take more time.
> > >  Increase the timer to 200 seconds.
> > 
> > Can we make this conditional somehow ?
> > 
> > I think it should probably be picked up from a runvar.

Thinking about this some more, there could be a runvar which would
multiply all of the guest-related timeouts.  The runvar name would have
the host ident in it (and a missing runvar would mean 1.0).  Then
ts-nested-setup could set this runvar.

This would also allow us to adjust the timeouts for other
host-specific reasons in the future (for example, if we grow some
hosts which are unreasonably slow or supposedly very fast).

> So how about reconsider this? I would suggest that just increase the
> timer here, since, though it is increased, the timer gets return as long as
> guest boots up, no impact to existing test cases.

But we care about not eliminating existing genuine failures, too.  If
a guest does not start up quickly, then that is a regression.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel