Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2015-02-04 at 15:13 +0000, Ian Campbell wrote:
> On Mon, 2015-02-02 at 20:03 +0200, Denis Drozdov wrote:
> > From: denys drozdov <denys.drozdov@xxxxxxxxxxxxxxx>
> > 
> > Make Credit2 and RT schedulers to run on arm platform
> > context_saved should be deferred on ARM after IRQs enabled
> 
> A better subject+message would be:
> 
>         xen/arm: Call context_saved() with interrupts enabled during context 
> switch
>         
>         This is a requirement of the scheduler interface, violating this
>         causes for example with the RT scheduler:
>                 <insert crash log here>
> 
> > Signed-off-by: denys drozdov <denys.drozdov@xxxxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> However I would like an ack from a scheduler person (e.g. George) before
> it gets applied.
> 
Deferring the call to context_saved() until below both
ctxt_switch_from() and ctxt_switch_to(), for ARM, like the patch is
doing seems ok to me.

As Jan noted already, it basically makes things look exactly as they
look in x86 already and, checking how booth credit2 and RTDS use
the .context_saved hook, all seems fine to me.

So, FWIW:

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel