Re: [Xen-devel] [PATCH 1/4] libxl: vcpuset: Return error values.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Konrad Rzeszutek Wilk writes ("[PATCH 1/4] libxl: vcpuset: Return error 
values."):
> The function does not return any values at all. Convert the
> internal libxl ones (ERROR_FAIL, ..., etc) to positive values
> and for the other cases just return standard libxl values.

This makes no sense to me, I'm afraid.  What is the return value type
of this function ?  Normally functions in libxl and many in xl return
a libxl error code.

I can't see any reason for ever writing -ERROR_FOO.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel