Re: [Xen-devel] [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.02.15 at 18:19, <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote:
>> +    union {
>> +        struct mem_event_paging_data                mem_paging;
>> +        struct mem_event_sharing_data               mem_sharing;
>> +        struct mem_event_mem_access_data            mem_access;
>> +        struct mem_event_mov_to_cr_data             mov_to_cr;
>> +        struct mem_event_mov_to_msr_data            mov_to_msr;
>> +        struct mem_event_software_breakpoint_data   software_breakpoint;
>> +        struct mem_event_singlestep_data            singlestep;
>> +    } data;
> 
> We typically call these unions "u" but that's up to the hypervisor guys
> really.

And yes, I agree we should be consistent with things like this.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel