[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/7] build system: stubdom targets now depends on mini-os target



On Mon, Feb 02, 2015 at 03:15:07PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH 6/7] build system: stubdom targets now depends on 
> mini-os target"):
> > So I once had something like:
> > 
> > $(XEN_ROOT)/Config.mk: mini-os-dir
> > 
> > Mini-os got clone and the build proceeded. But stubdom build still broke
> > miserably, because *FLAGS in stubdom/Makefile are not reevaluated.
> 
> This seems wrong to me because I would expect make to actually read
> the relevant file it has just built.  But given how bad the
> xen.git/stubdom makefiles are, I'm not convinced that trying to debug
> this will be very fruitful :-/.
> 

FWIW I did this test myself.

== Config.mk
include New.mk
== end Config.mk

== Makefile
include Config.mk

.PHONY: all
        @echo $(VAR)

New.mk:
        @echo "VAR = 123" > New.mk

VAR += ABC
== end Makefile

And the final result is VAR = "123 ABC".

However this is not the case for stubdom. :-/

I agree it won't be fruitful in debugging this.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.