[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxl: Wait for ballooning if free memory is increasing

On Thursday, January 29, 2015 10:14:26 AM Ian Campbell wrote:
> I'm thinking it would be clearer if the comment and the condition were
> logically inverted. e.g.:
>     /*
>      * If the amount of free mem has increased on this iteration (i.e.
>      * some progress has been made) then reset the retry counter.
>      */
>     if (freemem_kb > freemem_kb_prev) {
>         retries = MAX_RETRIES;
>         free_memkb_prev = free_memkb;
>     } else {
>         retires--;
>     }

Thanks for the comments, Ian. Inverting the logic makes sense, and I'll send a 
v2 shortly.

> > > Given that this new loop can take significantly longer to fail I wonder
> > > if we should add some progress logging? xl has an xtl logger instance
> > > available so using xtl_progress might be an easy option. Maybe a
> > > separate patch though.

xtl_progress looks interesting. I'll do some additional testing before I 
submit a patch containing this improvement.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.