Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.01.15 at 13:30, <denys.drozdov@xxxxxxxxxxxxxxx> wrote:
> From: denys drozdov <denys.drozdov@xxxxxxxxxxxxxxx>

There's a description missing here of _what_ (case) you are fixing.

> Change-Id: I9b315f213775b8410fe75cd96968dcb213ea287b

And the purpose of this line is unclear.

> --- a/xen/common/sched_rt.c
> +++ b/xen/common/sched_rt.c
> @@ -1010,8 +1010,9 @@ rt_context_saved(const struct scheduler *ops, struct 
> vcpu *vc)
>      struct rt_vcpu *snext = NULL;
>      struct rt_dom *sdom = NULL;
>      struct rt_private *prv = rt_priv(ops);
> -    cpumask_t *online;
> -    spinlock_t *lock = vcpu_schedule_lock_irq(vc);
> +    cpumask_t *online; 

You're introducing a trailing blank here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel