[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/6] xen/arm: Move in/out code to/from init section

Hi Ian,

On 30/01/15 11:30, Ian Campbell wrote:
> On Thu, 2015-01-29 at 18:32 +0000, Julien Grall wrote:
>> Hello,
>> Ping? Any more review for this version of this series?
> I was awaiting a version with the declarations in the right places as
> pointed out by Andy (including his point about definition vs. prototype
> I'm afraid, which is the style we use).

I'm not convince about your last point. We have many places (if not all
on ARM) where __init is used in the header.

Some of them was even added by you ;). So I would prefer if we keep
them, it's more readable. FWIW Linux does it too.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.