[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5/5] hvm_complete_assist_req: Tell caller we failed to send

>>> On 30.01.15 at 01:52, <dslutz@xxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2599,7 +2599,7 @@ static bool_t hvm_complete_assist_req(ioreq_t *p)
>          break;
>      }
> -    return 1;
> +    return 0; /* implicitly bins the i/o operation */
>  }

This change points out that having hvm_complete_assist_req() be a
separate function yet having only a single caller, and it returning
non-void with only a single possible return value isn't the best
arrangement. I think this should be brought back into
hvm_send_assist_req(), by inverting the if() condition there. Unless
there are intentions for it to have another caller, but in that case
it should still be made return void, with the caller choosing what to


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.