[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/balloon: cancel ballooning if adding new memory failed

On Thu, Jan 29, 2015 at 06:01:36PM +0000, David Vrabel wrote:
> On 29/01/15 13:36, Ian Campbell wrote:
> > On Mon, 2014-09-01 at 18:52 +0100, David Vrabel wrote:
> >> If the balloon driver is adding additional memory regions to the
> >> balloon and add_memory() fails it will likely continuously fail so
> >> cancel the balloon operation.
> >>
> >> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> >
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776448 and
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1304001 seem to
> > suggest this should be a candidate for stable backports?
> It's up to the distro kernel maintainer to request it if they think it
> is important.  It's a harmless message with no side effects so I don't
> think it qualifies.

It pollutes system logs, makes unnecessary confusion and from time to time
noise on various lists. Fix is trivial, so, why not. However, as David said
this is up to stable kernel maintainer.

If yes you should also backport commit fd8b79511349efd1f0decea920f61b93acb34a75
(xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered).
IIRC, both (trivial) patches are needed to fix this issue.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.