Re: [Xen-devel] [PATCH v4 06/21] libxl: introduce libxl__vnuma_config_check

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jan 29, 2015 at 11:04:15AM +0000, Ian Campbell wrote:
> On Wed, 2015-01-28 at 21:51 +0000, Wei Liu wrote:
> > On Wed, Jan 28, 2015 at 04:13:28PM +0000, Ian Campbell wrote:
> > > On Fri, 2015-01-23 at 11:13 +0000, Wei Liu wrote:
> > > > diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> > > > index 6d3ac58..39356ba 100644
> > > > --- a/tools/libxl/libxl_internal.h
> > > > +++ b/tools/libxl/libxl_internal.h
> > > > @@ -3394,6 +3394,11 @@ void libxl__numa_candidate_put_nodemap(libxl__gc 
> > > > *gc,
> > > >      libxl_bitmap_copy(CTX, &cndt->nodemap, nodemap);
> > > >  }
> > > >  
> > > > +/* Check if vNUMA config is valid. Returns 0 if valid. */
> > > 
> > > And on invalid? ERROR_FOO or just !0?
> > > 
> > > I see further down it is ERROR_INVAL, perhaps say so, and perhaps
> > > introduce ERROR_INVAL_VNUMA_CONFIGUATION or something.
> > 
> > I think ERROR_INVALID is good enough. There are logs along the line to
> > indicate what goes wrong.
> 
> The xapi guys have indicated that having to parse log lines is an issue
> for them, and are planning to help clean this up.
> 
> We are supposed to have a policy of specific error codes which we've not
> really done a good job of applying. I think we can start not adding new
> uses of generic error codes. (ERROR_FAIL is the worst offender, but
> ERROR_INVALID isn't much better IMHO).
> 

OK. I will use ERROR_INVAL_VNUMA_CONFIG.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel