[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] x86/VPMU: Handle APIC_LVTPC accesses

>>> On 29.01.15 at 16:28, <boris.ostrovsky@xxxxxxxxxx> wrote:
> However, if you insist on dropping all tags even for minor changes like 
> that (and "determining what "minor" is is a judgment call) I will 
> certainly do that in the future.

I don't mind you (and others) keeping them for minor changes. But a
small change isn't necessarily a minor one - that's why I pointed out
that this patch having caused a regression and hence having got
reverted is a relevant aspect here. Neither tester nor reviewer (in
this case the same person) spotted the issue up front. Having kept
Kevin is indeed a possibly acceptable thing (and I thought about
making this point in my earlier reply, but then decided it would only
risk confusion wrt the point I was trying to make).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.