Re: [Xen-devel] [PATCH] xen: random: Add missing include xen/cache.h

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2015-01-29 at 13:32 +0000, Julien Grall wrote:
> The commit f6c9698 " x86: allow reading MSR_IA32_TSC with XENPF_resource_op"
> introduced a built regression on ARM platform.
> 
> random.c:8:28: error: expected â=â, â,â, â;â, âasmâ or â__attribute__â before 
> âboot_randomâ
>  unsigned int __read_mostly boot_random;
>                             ^
> The define __read_mostly is defined in asm/cache.h which is included by
> other headers on x86 but not on ARM. Include xen/cache.h to fix the
> build.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Cc: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  xen/common/random.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/common/random.c b/xen/common/random.c
> index cb9187c..fb805b0 100644
> --- a/xen/common/random.c
> +++ b/xen/common/random.c
> @@ -1,3 +1,4 @@
> +#include <xen/cache.h>
>  #include <xen/init.h>
>  #include <xen/percpu.h>
>  #include <xen/random.h>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel