Re: [Xen-devel] [PATCH v3 22/24] tools/libxl: arm: Use an higher value for the GIC phandle

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 29 Jan 2015, Julien Grall wrote:
> On 29/01/15 11:07, Stefano Stabellini wrote:
> > On Tue, 13 Jan 2015, Julien Grall wrote:
> >> The partial device tree may contains phandle. The Device Tree Compiler
> >> tends to allocate the phandle from 1.
> >>
> >> Reserve the ID 65000 for the GIC phandle. I think we can safely assume
> >> that the partial device tree will never contain a such ID.
> >>
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> >> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> >>
> > 
> > Shouldn't we at least check that the partial device tree doesn't contain
> > a conflicting phandle?
> 
> I don't think so. This will unlikely happen, and if it happens the guest
> will crash with an obvious error.

It is good that the error is obvious.

But how expensive is to check for it?
Think about the poor user that ends up in this situation: the fact that
is unlikely only makes it harder for a user to figure out what to do to
fix it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel