Re: [Xen-devel] [PATCH OSSTEST v4 00/13] support for ARM32 arndale and cubietruck platforms

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [Xen-devel] [PATCH OSSTEST v4 00/13] support for 
ARM32 arndale and cubietruck platforms"):
> I think this is a combination of ee5e442f15eb "Osstest/Debian: Add 0x
> prefix to $filesize" from this series and a much older change in
> e6e9078c80d6 "Debian: more corrections to arm u-boot rune" which removed
> a space from before the ">", probably because I couldn't remember what
> it was for...

Nnng.

> It turns out that the ext2load command on midway only sets filesize with
> the 0x prefix, but e.g. tftp doesn't. This doesn't occur on arndale or
> cubietruck which has much newer u-boot which has this bug fixed (not
> sure by what but [0] look like candidates).

Oh god oh god the horror.

> Based on the email threads referenced by ee5e442f15e[1] I think we
> should consider this a quirk/bug on the midway platform.

OK.

> In theory I could try upgrading the u-boot firmware on these systems
> (it's still supported by mainline u-boot), but to be honest with Calxeda
> no longer existing I'm reluctant to do anything which might have any
> chance of bricking the systems.
> 
> I'm not sure how specific to make this quirk and whether it is worth
> doing via the hostdb or just directly in Debian.pm. Options:
> 
>       * Make the addition of the 0x prefix conditional on !
>         platform-midway

I think this would be an abuse of platform-*.  You've already done
this kind of thing once with equiv-marilith in Osstest/CXFabric.pm and
I think I should have put my foot down then...

>       * A similar host flag to control the addition (or, more likely, 
>         the omission of) of the 0x

That would be fine, although AFAICT we don't really have any quirks in
the hostflags already.  It should probably be quirk-something.

>       * Add a new host prop e.g. UBootLoadFilesizePrefix, defaulting to
>         0x and set to '' on midway machines

That would be fine too (although do you expect any values other than
'' and 0x?)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel