Re: [Xen-devel] [PATCH v3 03/24] xen/dts: Allow only IRQ translation that are mapped to main GIC

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 13 Jan 2015, Julien Grall wrote:
> Xen is only able to handle one GIC controller. Some platform may contain
> other interrupt controller.
> 
> Make sure to only translate IRQ mapped into the GIC handled by Xen.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

> 
>     Changes in v3:
>         - Patch was previously sent a separate series [1]
>         - Rework the comment in dt_irq_translate.
> 
>     Changelog based on the separate series:
> 
>     Changes in v3:
>         - Add an ASSERT to check that dt_interrupt_controller is not
>         NULL.
> 
>     Changes in v2:
>         - Fix compilation...
> 
>     [1] https://patches.linaro.org/33312/
> ---
>  xen/common/device_tree.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index f471008..bb9d7ce 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -1058,8 +1058,14 @@ int dt_irq_translate(const struct dt_raw_irq *raw,
>                       struct dt_irq *out_irq)
>  {
>      ASSERT(dt_irq_xlate != NULL);
> +    ASSERT(dt_interrupt_controller != NULL);
>  
> -    /* TODO: Retrieve the right irq_xlate. This is only work for the gic */
> +    /*
> +     * TODO: Retrieve the right irq_xlate. This is only works for the primary
> +     * interrupt controller.
> +     */
> +    if ( raw->controller != dt_interrupt_controller )
> +        return -EINVAL;
>  
>      return dt_irq_xlate(raw->specifier, raw->size,
>                          &out_irq->irq, &out_irq->type);
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel