Re: [Xen-devel] [PATCH v3 3/3] xen/arm: Introduce support for Renesas R-Car Gen2 platform

[Oleksandr Tyshchenko <oleksandr.tyshchenko@xxxxxxxxxxxxxxx>]

Hi Ian

On Wed, Jan 28, 2015 at 3:26 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Fri, 2015-01-23 at 17:33 +0200, Oleksandr Tyshchenko wrote:
>> From: Iurii Konovalenko <iurii.konovalenko@xxxxxxxxxxxxxxx>
>>
>> Signed-off-by: Iurii Konovalenko <iurii.konovalenko@xxxxxxxxxxxxxxx>
>> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> ---
>>  xen/arch/arm/platforms/Makefile   |  1 +
>>  xen/arch/arm/platforms/shmobile.c | 71 
>> +++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 72 insertions(+)
>>  create mode 100644 xen/arch/arm/platforms/shmobile.c
>>
>> diff --git a/xen/arch/arm/platforms/Makefile 
>> b/xen/arch/arm/platforms/Makefile
>> index 8f47c16..29e931a 100644
>> --- a/xen/arch/arm/platforms/Makefile
>> +++ b/xen/arch/arm/platforms/Makefile
>> @@ -4,5 +4,6 @@ obj-$(CONFIG_ARM_32) += exynos5.o
>>  obj-$(CONFIG_ARM_32) += midway.o
>>  obj-$(CONFIG_ARM_32) += omap5.o
>>  obj-$(CONFIG_ARM_32) += sunxi.o
>> +obj-$(CONFIG_ARM_32) += shmobile.o
>
> Everything else calls the platform rcar. How does shmobile relate to
> that?
Unfortunately, the author of this patch in vacation now.

Perhaps Iurii took this name from kernel part (Linux/arch/arm/mach-shmobile/...)
where the arch specific things for this platform is located,
especially the SMP and timer support.

I would rename shmobile to rcar2.

>
> (I must confess I thought sh-mobile was a process architecture of its
> own, not an ARM thing)
>
> Ian.
>



-- 

Oleksandr Tyshchenko | Embedded Dev
GlobalLogic
www.globallogic.com

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel