Re: [Xen-devel] [PATCH v2 04/12] xen/arm: device: Rename device_type into device_match

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 27/01/2015 16:13, Stefano Stabellini wrote:
> On Tue, 27 Jan 2015, Julien Grall wrote:
> > Hi Stefano,
> >
> > On 27/01/15 16:05, Stefano Stabellini wrote:
> > > On Fri, 16 Jan 2015, Julien Grall wrote:
> > > > This enum was used for matching a specific device and not to get the
> > > > type of device.
> > > >
> > > > Hence the name device_type will be used for another purpose later.
> > > >
> > > > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > > If you really want to rename this field, please find a more descriptive
> > > name for it. device_match doesn't really tell me what we are trying to
> > > match against.  At least device_type would tell me that we are matching
> > > against the type.
> > I was struggling to find a correct name. For me device_type refers to
> > PCI/platform device. And it will be used this way later.
> >
> > Maybe device_category?
> Yes, or device_class
device_class seems better. I will use it in the next version.

Regards,


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel