Re: [Xen-devel] [PATCH v1 00/21] Xen/ARM guest support

[Laszlo Ersek <lersek@xxxxxxxxxx>]

On 01/23/15 16:02, Ard Biesheuvel wrote:

>  ArmPkg/Drivers/TimerDxe/TimerDxe.c                 |  14 +-
>  .../ArmVirtualizationPkg/ArmVirtualizationPkg.dec  |   3 +-
>  .../ArmVirtualizationPkg/ArmVirtualizationQemu.dsc |   3 -
>  .../ArmVirtualizationPkg/ArmVirtualizationXen.dsc  | 274 +++++++++++++
>  .../ArmVirtualizationPkg/ArmVirtualizationXen.fdf  | 337 ++++++++++++++++
>  .../ArmVirtualizationPkg/Include/Guid/FdtHob.h     |  26 ++
>  .../ArmVirtualizationMemoryInitPeiLib.c            |  91 +++++
>  .../ArmVirtualizationMemoryInitPeiLib.inf          |  64 +++
>  .../AARCH64/MemnodeParser.S                        | 232 +++++++++++
>  .../AARCH64/RelocatableVirtHelper.S                | 161 ++++++++
>  .../ArmVirtualizationPlatformLib.inf               |   1 +
>  .../ArmXenRelocatablePlatformLib.inf               |  66 ++++
>  .../ArmVirtualizationPlatformLib/RelocatableVirt.c |  78 ++++
>  .../Library/ArmVirtualizationPlatformLib/Virt.c    |  48 +--
>  .../ArmVirtualizationPlatformLib/XenVirtMem.c      |  83 ++++
>  .../Library/PlatformPeiLib/PlatformPeiLib.c        |  75 +++-
>  .../Library/PlatformPeiLib/PlatformPeiLib.inf      |   3 -
>  .../ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.c   | 129 +++++-
>  .../ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.inf |   5 +-
>  ArmPlatformPkg/PrePi/AArch64/ModuleEntryPoint.S    |  51 ++-
>  ArmPlatformPkg/PrePi/MainMPCore.c                  |   5 +-
>  ArmPlatformPkg/PrePi/MainUniCore.c                 |   2 +-
>  ArmPlatformPkg/PrePi/MainUniCoreRelocatable.c      |  38 ++
>  ArmPlatformPkg/PrePi/PeiUniCoreRelocatable.inf     | 108 +++++
>  ArmPlatformPkg/PrePi/PrePi.c                       |  25 +-
>  ArmPlatformPkg/PrePi/PrePi.h                       |   3 +-
>  ArmPlatformPkg/PrePi/Scripts/PrePi-PIE.lds         |  28 ++
>  OvmfPkg/Include/Guid/XenBusRootDevice.h            |  24 ++
>  .../Include/IndustryStandard/Xen/arch-arm/xen.h    | 436 
> +++++++++++++++++++++
>  OvmfPkg/Include/IndustryStandard/Xen/io/console.h  |  51 +++
>  OvmfPkg/Include/IndustryStandard/Xen/xen.h         |   7 +-
>  OvmfPkg/Include/Library/XenHypercallLib.h          |  78 ++++
>  OvmfPkg/Include/Protocol/XenIo.h                   |  48 +++
>  .../XenConsoleSerialPortLib.c                      | 147 +++++++
>  .../XenConsoleSerialPortLib.inf                    |  34 ++
>  .../Library/XenHypercallLib/Aarch64/Hypercall.S    |  26 ++
>  OvmfPkg/Library/XenHypercallLib/Arm/Hypercall.S    |  25 ++
>  .../XenHypercallLib}/Ia32/hypercall.nasm           |   6 +-
>  .../XenHypercallLib}/X64/hypercall.nasm            |   6 +-
>  .../Library/XenHypercallLib/XenHypercallLibArm.inf |  40 ++
>  .../XenHypercallLib/XenHypercallLibCommon.c        |  63 +++
>  .../Library/XenHypercallLib/XenHypercallLibIntel.c |  77 ++++
>  .../XenHypercallLib/XenHypercallLibIntel.inf       |  52 +++
>  .../XenRealTimeClockLib/XenRealTimeClockLib.c      | 196 +++++++++
>  .../XenRealTimeClockLib/XenRealTimeClockLib.inf    |  38 ++
>  OvmfPkg/OvmfPkg.dec                                |   6 +
>  OvmfPkg/OvmfPkgIa32.dsc                            |   1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                         |   1 +
>  OvmfPkg/OvmfPkgX64.dsc                             |   1 +
>  OvmfPkg/XenBusDxe/AtomicsGcc.c                     |  44 +++
>  OvmfPkg/XenBusDxe/ComponentName.c                  |   2 +-
>  OvmfPkg/XenBusDxe/EventChannel.c                   |  14 +-
>  OvmfPkg/XenBusDxe/GrantTable.c                     |  15 +-
>  OvmfPkg/XenBusDxe/GrantTable.h                     |   3 +-
>  OvmfPkg/XenBusDxe/XenBus.c                         |   6 +-
>  OvmfPkg/XenBusDxe/XenBusDxe.c                      | 241 ++++++++++--
>  OvmfPkg/XenBusDxe/XenBusDxe.h                      |   8 +-
>  OvmfPkg/XenBusDxe/XenBusDxe.inf                    |  15 +-
>  OvmfPkg/XenBusDxe/XenHypercall.c                   | 118 ------
>  OvmfPkg/XenBusDxe/XenHypercall.h                   | 113 ------
>  OvmfPkg/XenBusDxe/XenStore.c                       |   6 +-
>  OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.h                  |   4 -

Just a very quick skim for now, because you'll probably submit a v2 with
the more fine-grained structure requested by Stefano (which I welcome,
because it'll be easier to review).

First: please don't forget --stat=150 next time :)

Thanks
Laszlo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel