Re: [Xen-devel] [PATCH 12/14] xen-blkback: safely unmap grants in case they are still in use

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

El 23/01/15 a les 13.02, David Vrabel ha escrit:
> On 19/01/15 15:51, David Vrabel wrote:
>> From: Jenny Herbert <jennifer.herbert@xxxxxxxxxx>
>>
>> Use gnttab_unmap_refs_async() to wait until the mapped pages are no
>> longer in use before unmapping them.
>>
>> This allows blkback to use network storage which may retain refs to
>> pages in queued skbs after the block I/O has completed.
> 
> Roger, I'd appreciate a review of this blkback change.

Done. BTW, have you tested the patch setting:

# echo 128 > /sys/module/xen_blkback/parameters/max_persistent_grants

Without this some of the newly introduced code-paths would remain
untested (replace 128 with whatever you want, or even 0).

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel