Re: [Xen-devel] [RFC PATCH V2 4/8] x86/hvm: rename hvm_memory_event_* functions to hvm_event_*

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Jan 22, 2015 at 4:56 PM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> On 18/01/15 15:17, Tamas K Lengyel wrote:
>> The function names currently imply that these events are to be delivered via
>> the memory_event subsystem. However, the naming is confusing as these events
>> have nothing to do with actual memory events. Simply naming these functions
>> hvm_event_* more accurately describe their usage.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
>> ---
>>  docs/misc/pvh-readme.txt      |  2 +-
>>  xen/arch/x86/hvm/hvm.c        | 50 
>> +++++++++++++++++++++----------------------
>>  xen/arch/x86/hvm/vmx/vmx.c    |  6 +++---
>>  xen/include/asm-x86/hvm/hvm.h | 12 +++++------
>>  4 files changed, 35 insertions(+), 35 deletions(-)
>>
>> diff --git a/docs/misc/pvh-readme.txt b/docs/misc/pvh-readme.txt
>> index c5b3de4..bbd9dbe 100644
>> --- a/docs/misc/pvh-readme.txt
>> +++ b/docs/misc/pvh-readme.txt
>> @@ -49,7 +49,7 @@ Following remain to be done for PVH:
>>     - AMD port.
>>     - 32bit PVH guest support in both linux and xen. Xen changes are tagged
>>       "32bitfixme".
>> -   - Add support for monitoring guest behavior. See hvm_memory_event* 
>> functions
>> +   - Add support for monitoring guest behavior. See hvm_event* functions
>>       in hvm.c
>>     - vcpu hotplug support
>>     - Live migration of PVH guests.
>> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
>> index f936d51..1968865 100644
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -3229,7 +3229,7 @@ int hvm_set_cr0(unsigned long value)
>>          hvm_funcs.handle_cd(v, value);
>>
>>      hvm_update_cr(v, 0, value);
>> -    hvm_memory_event_cr0(value, old_value);
>> +    hvm_event_cr0(value, old_value);
>
> I feel that if we are naming these things consistently, "vm_event_$FOO"
> would be better than "hvm_event_$FOO".  A while ago there was interest
> in getting bits of the mem_event infrastructure working for PV guests,
> and the vm_event infrastructure is not inherently hvm specific.
>
> ~Andrew

Surely.

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel