Re: [Xen-devel] [RFC PATCH V2 8/8] x86/hvm: factor out vm_event related functions into separate file

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 18/01/15 15:18, Tamas K Lengyel wrote:
> -void hvm_event_cr0(unsigned long value, unsigned long old)
> -{
> -    vm_event_request_t req = {
> -        .reason = VM_EVENT_REASON_CR0,
> -        .vcpu_id = current->vcpu_id,
> -        .cr_event.new_value = value,
> -        .cr_event.old_value = old
> -    };
> -
> -    long parameters = current->domain->arch.hvm_domain
> -                        .params[HVM_PARAM_MEMORY_EVENT_CR0];

(I realise this is probably not the best patch, but) As we are redoing
the API with a hope of including PV and ARM guests, can we remove this
use of hvm params?  This would probably involve a new setup hypercall
subop to set up reporting preferences.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel