Re: [Xen-devel] [PATCH OSSTEST v2 09/18] Toolstack: Refactor consolecmd handling

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-01-20 at 18:34 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 09/18] Toolstack: Refactor consolecmd 
> handling"):
> ...
> > diff --git a/Osstest/Toolstack/xend.pm b/Osstest/Toolstack/xend.pm
> > index c921c20..896d949 100644
> > --- a/Osstest/Toolstack/xend.pm
> > +++ b/Osstest/Toolstack/xend.pm
> > @@ -36,5 +36,6 @@ sub new {
> >  # Defer to xl driver for most things
> >  sub destroy { return &Osstest::Toolstack::xl::destroy; }
> >  sub create { return &Osstest::Toolstack::xl::create; }
> > +sub consolecmd { return &Osstest::Toolstack::xl::consolecmd; }
> 
> I hesitate to suggest this, but perhaps Exporter(3pm)'s inheritance
> feature (@ISA, I think) might do this more automatically ?

Perhaps, I can't seem to find Exporter(3pm) any where either in Debian
or online. Lots of Exporter::Lite, ::Simple, ::Heavy type stuff
though...

> > diff --git a/ts-logs-capture b/ts-logs-capture
> > index 841ad5a..dbca13a 100755
> > --- a/ts-logs-capture
> > +++ b/ts-logs-capture
> > @@ -195,7 +195,7 @@ sub fetch_logs_guest ($) {
> >          logm("cannot find domid: $@");
> >          return;
> >      }
> > -    my $consolecmd= toolstack($ho)->{Command}." console $gho->{Name}";
> > +    my $consolecmd= toolstack($ho)->consolecmd($gho);
> >      try_cmd_output_save("sleep 1 | $consolecmd | cat",
> >                          "guest-$gho->{Name}-console");
> 
> Does `virsh console' work the same way as xl console, particularly wrt
> this weird thing with the sleep 1 etc. ?

TBH I'm not sure. What is the reason for that weirdness?

Ultimately libvirt/virsh opens the pty directly as opposed to via the
xenconsole binary, AFAICT.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel