[Xen-devel] [PATCH OSSTEST v5 06/14] Osstest/Debian.pm: Refactor common kernel cmdline setup.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
v5: New patch, based on review of Osstest/Debian: support adding a
    rootdelay property to bootargs
---
 Osstest/Debian.pm | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 0b047df..1f7a4f0 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -114,6 +114,19 @@ sub bl_getmenu_open ($$$) {
     return $f;
 }
 
+sub uboot_common_kernel_bootargs ($)
+{
+    my ($ho) = @_;
+
+    my $root= target_guest_lv_name($ho,"root");
+
+    my @bootargs;
+    push @bootargs, "ro";
+    push @bootargs, "root=$root";
+
+    return @bootargs;
+}
+
 sub uboot_scr_load_dtb () {
     return <<'END';
 if test -z "\${fdt_addr}" && test -n "\${fdtfile}" ; then
@@ -134,12 +147,8 @@ sub setupboot_uboot ($$$) {
        my $kern = "vmlinuz-$want_kernver";
        my $initrd = "initrd.img-$want_kernver";
 
-       my $root= target_guest_lv_name($ho,"root");
-
-       my @xenkopt;
+       my @xenkopt = uboot_common_kernel_bootargs($ho);
        push @xenkopt, $xenkopt;
-       push @xenkopt, "ro";
-       push @xenkopt, "root=$root";
 
        $xenkopt = join ' ', @xenkopt;
 
@@ -698,12 +707,10 @@ END
     }
 
     if ( $ho->{Flags}{'need-uboot-bootscr'} ) {
-       my @bootargs;
+       my @bootargs = uboot_common_kernel_bootargs($ho);
 
-       my $root=target_guest_lv_name($ho,"root");
        my $console=get_host_native_linux_console($ho);
 
-       push @bootargs, "root=$root";
        push @bootargs, "console=$console" unless $console eq "NONE";
 
        my $bootargs = join ' ', @bootargs;
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel