Re: [Xen-devel] [PATCH v5 0/6] enable Memory Bandwidth Monitoring (MBM) for VMs

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Thu, Jan 22, 2015 at 07:59:39AM +0000, Jan Beulich wrote:
> >>> On 22.01.15 at 02:12, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> > On Wed, Jan 21, 2015 at 11:28:34AM +0000, Jan Beulich wrote:
> >> >>> On 21.01.15 at 12:19, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> >> > Changes from v4:
> >> > * Make the counter read and timestamp read atomic by disable IRQ;
> >> > * Treat MSR_IA32_TSC as a special case and return NOW() for read path;
> >> > * Add MBM description in xl command line.
> >> 
> >> You should really have answered Andrew's question regarding the
> >> use of NOW() vs RDTSC before posting this new series.
> > 
> > As I have adopted it so I agree with Andrew's suggestion. NOW() is much
> > fullfill my requirement. But perhaps not so semantic consistent with
> > MSR_IA32_TSC?
> 
> Exactly - I didn't look at the patch itself yet, but at the very least
> this would need to be very clearly documented in the public header.

No problem. Or it's our time to create "XEN_RESOURCE_OP_SYSTIME_READ"
sub-op to omit adding such specific comment in platform.h?

Chao
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel