[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH OSSTEST v4 10/13] ts-kernel-build: Adjust kernel .config to work on the arndale boards.

On Wed, 2015-01-21 at 12:05 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v4 10/13] ts-kernel-build: Adjust kernel 
> .config to work on the arndale boards."):
> > Various drivers are missing from multi_v7_defconfig in v3.16, also
> > some drivers which don't play nice are enabled by default, so remove
> > them.
> ...
> > +# Enabling Exynos4 forces wierd CONFIG_HZ==200, and we don't
> > +# support that platform anyway.
> > +setopt CONFIG_ARCH_EXYNOS4 n
> > +
> > +# Having these on breaks USB
> > +
> > +# These cause i2c bus timeout errors on boot.
> > +# 
> > https://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-reviews/f1DW9NcSPVU?
> > +# http://patchwork.ozlabs.org/patch/337812/
> > +setopt CONFIG_SENSORS_LM90 n
> > +setopt CONFIG_ICS932S401 n
> I think these should be gated on the kernel version and/or arch or
> something.  After all, disabling modules is a workaround (and risks
> making things not work in the future in an annoyingly mysterious way).

Arch I can easily do.

Not sure how easy it will be to get the kern ver, currently we get it
from the name of the subdir created in /lib/modules by the kernel
install, which is too late of course.

Not sure if there is some other surrogate we could use.

FWIW LM90 is some i2c temperature sensor thing which I doubt we are
exercising (i.e. we aren't installed lmsensors packages) and ICS932S401
is some equally uninteresting i2c sensor device. I think it's pretty
unlikely we would suddenly trip over an x86 system with these and for
ARM each new platform is likely to need some dev work to add etc anyway.
In neither case do I think we would miss these devices in practice.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.