Re: [Xen-devel] [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 08/18] Toolstack: Refactor guest 
lifecycle."):
> Implement destory/create as per toolstack methods, including implementing the
> libvirt version which previously didn't work. To do this we use the virsh
> capability to convert an xl/xm style config file into the correct XML.
> 
> xend basically calls into the xl helper since they are compatible.
> 
> xl/x, uses ->{Command} which will eventually become private.
...
> diff --git a/ts-guest-saverestore b/ts-guest-saverestore
> index 9e04ae9..8911aed 100755
> --- a/ts-guest-saverestore
> +++ b/ts-guest-saverestore
> @@ -38,7 +38,7 @@ sub restore () {
>                   toolstack($ho)->{Command}
>                   ." restore "
>                   .(toolstack($ho)->{RestoreNeedsConfig} ?
> -                   $r{ $gho->{Guest}.'_'. toolstack($ho)->{CfgPathVar} } : 
> '')
> +                   $gho->{CfgPath} : '')
>                   ." image", 200);

This hunk doesn't seem to be covered by the commit message ?

> -    target_cmd_root($ho, $cmd, 30);
> +    toolstack($ho)->create($r{ $gho->{Guest}.'_'. 
> toolstack($ho)->{CfgPathVar} });

Perhaps the toolstack create method should take the $gho rather than
the config file pathname, like the destroy method does ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel