Re: [Xen-devel] [PATCH 05/10] xen/arm: vgic-v3: Document the current restrictions

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 20/01/15 16:00, Ian Campbell wrote:
> On Mon, 2015-01-19 at 16:29 +0000, Julien Grall wrote:
>> The current vGIC v3 driver doesn't fully implement GICv3 spec:
>>     - GICv3 backward compatibility is not supported (GICD_CTLR.ARE = 0)
> 
> I think you meant GICv2 here as you did in the code.

Yes.

> In which case I believe this is optional in the spec, i.e. we can be
> compliant and still not implement this.
> 
> That's not to say it isn't desirable, but this is a TODO item, not a
> spec non-conformity issue.

Right, I should rename the section to TODO.

>>     - A processor can only access his own redistributor. For buggy
>>     assumption, the current code bank the redistributors MMIO.
> 
> What assumption? It's not clear if you mean that a foreign redistributor
> should not be accessible and is, or if it should be accessible and
> isn't.

Every redistributor (one per processor) are mapped in distinct MMIO region.

Unlike the distributor, the redistributor is not banked.

Our current implementation (see vgic_v3_rdistr_mmio_write) consider that
the redistributor is banked and replicate n-times in the memory.

If you give a look to the redistributor iniatialization (see Xen and
Linux GICv3 code). The code will go through all the redistributors and
check GICR_TYPER to see if the processor is associated to this
redistributor.

I'm not sure how the redistributor should behave if it's accessed by
another processor. But I'm sure it's wrong to bank it.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel