Re: [Xen-devel] [PATCH 01/10] xen/arm: vgic-v3: Correctly set GICD_TYPER.IDbits

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2015-01-19 at 16:29 +0000, Julien Grall wrote:
> +
> +        *r |= ((order - 1) << GICD_TYPE_ID_BITS_SHIFT) & 
> GICD_TYPE_ID_BITS_MASK;

Please can you calculate the value and then construct *r in one go, so
it is easier to see all the parts in one place. Thanks.

I wonder if this field is now complex enough to warrant the union+struct
approach we use for other registers (e.g. the ESR).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel