Re: [Xen-devel] [PATCH v2 4/4] libxl: Add interface for querying hypervisor about PCI topology

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 01/19/2015 12:32 PM, Ian Campbell wrote:
> > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> > index 0a123f1..eb83f0a 100644
> > --- a/tools/libxl/libxl.h
> > +++ b/tools/libxl/libxl.h
> > @@ -1070,6 +1070,10 @@ void libxl_vminfo_list_free(libxl_vminfo *list, int 
> > nb_vm);
> >   libxl_cputopology *libxl_get_cpu_topology(libxl_ctx *ctx, int *nb_cpu_out);
> >   void libxl_cputopology_list_free(libxl_cputopology *, int nb_cpu);
> >   
> > +#define LIBXL_PCITOPOLOGY_INVALID_ENTRY (~(uint32_t)0)
> > +libxl_pcitopology *libxl_get_pci_topology(libxl_ctx *ctx, int *num_dev);
> > +void libxl_pcitopology_list_free(libxl_pcitopology *, int num_dev);
> Needs a #define LIBXL_HAVE_FOO #define to advertise the new
> functionality.
Ah, yes, Wei pointed it out to me earlier and I missed it.

> > diff --git a/tools/libxl/libxl_linux.c b/tools/libxl/libxl_linux.c
> > index ea5d8c1..07428c0 100644
> > --- a/tools/libxl/libxl_linux.c
> > +++ b/tools/libxl/libxl_linux.c
> > @@ -279,3 +279,74 @@ libxl_device_model_version 
> > libxl__default_device_model(libxl__gc *gc)
> >   {
> >       return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
> >   }
> > +
> > +/* These two routines are "inspired" by pciutils */
> "inspired" in a licensing consistent way?
pciutils is licensed under GPL2 (e.g. 
http://git.kernel.org/cgit/utils/pciutils/pciutils.git/tree/COPYING) so 
this would be consistent.
Thanks.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel