Re: [Xen-devel] [Patch] static symbols in credit2

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

Hi Uma,

AFAICT, this is the second version of the patch, that you produced after
receiving feedback on your first submission, isn't it? In that case, you
should make that evident in the subject, using something like "[PATCH
v2]"

On Wed, 2015-01-14 at 22:30 +0530, Uma Sharma wrote:
> Changing param varibales in sched_credit2.c as static where required.
> 
> Signed-off-by: Uma Sharma <uma.sharma523@xxxxxxxxx>
> 
> ---
>
And also, you should put a summary of what changed in this new
submission, wrt the previous one(s). We usually put it here, in the
changelog, below the '---' marker.

In this case, that is pretty straightforward, but please do, if only to
get used to it! :-)

> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 1ca521b..9dd8e84 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -163,7 +163,7 @@
>  #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request)
>  
> 
> -int opt_migrate_resist=500;
> +static int opt_migrate_resist = 500;
>  integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
>  
Sorry for mentioning this only now, but, what about "__read_mostly" as
an attribute (for others too) ?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel