[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/4] xen/many: Drop redundant MAX_VIRT_CPUS bounds checks

>>> On 19.01.15 at 12:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> In all 4 cases, visible in the context are bounds check against d->max_vcpus.
> Domain building will ensure that d->max_vcpus never exceeds an appropriate
> bound.  In the x86 case, different types of domains have different maxima 
> for
> vcpus, making the checks wrong as opposed to simply redundant.
> For vpsci in ARM, 'vcpuid' is an unsigned type so could never be less than 
> 0.
> For the common changes to do_{,compat}_vcpu_op(), these changes do result in 
> a
> guest visible change, but only in so far as certain invalid vcpu ids will 
> now
> fail with -ENOENT rather than -EINVAL.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.