Re: [Xen-devel] [PATCH v2 2/4] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2015-01-05 at 21:18 -0500, Boris Ostrovsky wrote:
> Instead of copying data for each field in xen_sysctl_topologyinfo separately
> put cpu/socket/node into a single structure and do a single copy for each
> processor.
> 
> There is also no need to copy whole op to user at the end, max_cpu_index is
> sufficient
> 
> Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the fact
> that these are used for CPU topology. Subsequent patch will add support for
> PCI topology sysctl.
> 
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> ---
>  tools/libxc/include/xenctrl.h     |    4 +-
>  tools/libxc/xc_misc.c             |   10 +++---
>  tools/libxl/libxl.c               |   52 ++++++++++-----------------
>  tools/misc/xenpm.c                |   69 ++++++++++++++----------------------
>  tools/python/xen/lowlevel/xc/xc.c |   40 +++++++--------------

FWIW the tools changes look correct to me (as expected, being largely
mechanical renamings), I think there's still a decision to be made about
which hypercall this is to be a sub-op of, but if the hypervisor guys
agree on this approach then the tools part is:
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(I'm not made keen on cputopo as an abbreviation, but not enough to ask
you to type "logy" over and over ;-))

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel