Re: [Xen-devel] [PATCH] re-order struct domain fields

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2015-01-19 at 15:42 +0000, Jan Beulich wrote:
> ... to reduce padding holes.
> 
> I also wonder whether having independent spin locks side by side is
> really a good thing cache-line-bouncing-wise.

AIUI the general wisdom is to put each spinlock next to the data it
protects (I suppose on the assumption that after acquiring the lock you
will next touch that data).

Is the problem is that the domain_lock doesn't actually protect anything
in this struct since it is a more umbrella lock, so there is nothing to
put next to it?

You could move either it or the page lock below all the page counts
stuff.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel