Re: [Xen-devel] [PATCH] xsm/evtchn: Never pretend to have successfully created a Xen event channel

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 19.01.15 at 11:45, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1155,21 +1155,25 @@ int alloc_unbound_xen_event_channel(
>  
>      spin_lock(&d->event_lock);
>  
> -    if ( (port = get_free_port(d)) < 0 )
> +    rc = get_free_port(d);
> +    if ( rc < 0 )
>          goto out;
> +    port = rc;

While this is kind of unrelated to the real change done in this patch,
I'm fine with it being here, but I wonder whether this shouldn't be
accompanied by a type change of "port" (to evtchn_port_t).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel