Re: [Xen-devel] [PATCH] xen/arm: Update documentation in the public header arch-arm.h

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2015-01-15 at 13:53 +0000, Julien Grall wrote:
> Hi,
> 
> On 15/01/15 13:48, Ian Campbell wrote:
> > On Wed, 2015-01-14 at 12:53 +0000, Julien Grall wrote:
> >> Minor updates to the documentation in xen/include/public/arch-arm.h:
> >>     - Comments coding style fix
> >>     - Typoes
> >>     - Update the list of supported hypercalls by ARM
> >>     - Remove uncessary comment about 64bit.
> > 
> > "unnecessary"
> > 
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> >> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> >> Cc: Keir Fraser <keir@xxxxxxx>
> >>
> >> ---
> >>     I'm not sure if we usually backport documentation. If so, I'd like
> >>     to request backporting for Xen 4.5.
> > 
> > I don't think we need to TBH, any development should be against unstable
> > and we publish these headers online for ease of access.
> 
> Ok. I'm fine with that.
> 
> >> + *   All generic sub-operations
> >>   *
> >>   *  HYPERVISOR_domctl
> >>   *   All generic sub-operations, with the exception of:
> >> - *    * XEN_DOMCTL_iomem_permission (not yet implemented)
> >>   *    * XEN_DOMCTL_irq_permission (not yet implemented)
> >>   *
> >>   *  HYPERVISOR_sched_op
> >> @@ -183,7 +178,7 @@
> >>   * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field
> >>   * in a struct in memory. On ARM is always 8 bytes sizes and 8 bytes
> >>   * aligned.
> >> - * XEN_GUEST_HANDLE_PARAM represent a guest pointer, when passed as an
> >> + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an
> >>   * hypercall argument. It is 4 bytes on aarch and 8 bytes on aarch64.
> > 
> > Is there a "32" missing in this last sentence do you think? (not the bit
> > you touched)
> 
> I think yes. Could you fix it when you will commit the patch?

Sure. I'll apply it now.

> 
> > I can fix the "unnecessary" on commit, so:
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Thanks,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel