Re: [Xen-devel] [PATCH v3 15/19] libxc: allocate memory with vNUMA information for HVM guest

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Jan 13, 2015 at 08:44:29PM +0000, Wei Liu wrote:
> On Tue, Jan 13, 2015 at 01:15:21PM -0500, Konrad Rzeszutek Wilk wrote:
> > On Tue, Jan 13, 2015 at 12:11:43PM +0000, Wei Liu wrote:
> > > The algorithm is more or less the same as the one used for PV guest.
> > > Libxc gets hold of the mapping of vnode to pnode and size of each vnode
> > > then allocate memory accordingly.
> > 
> > Could you split this patch in two? One part for the adding of the code
> > and the other for moving the existing code around?
> > 
> 
> The structures added are just a few lines. On one hand two Ians
> complained I wrote patches that only added structures, on the other you
> complained I bundled them with functional code. It's hard to please
> everyone isn't it. :-)
> 
> Jokes aside, I'm not sure if the above paragraph answers your question.
> Which part of code is "added" and which part of code is "moved around"?

The existing code that is just moved by tab could have a seperate patch
which is a non-functional. That is - it does not change the behavior
of the code - just moves it around.
> 
> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel