Re: [Xen-devel] [PATCH v3 10/19] xen: handle XENMEM_get_vnumainfo in compat_memory_op

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.01.15 at 13:11, <wei.liu2@xxxxxxxxxx> wrote:
>          rc = do_memory_op(cmd, nat.hnd);
> +        if ( rc == -ENOBUFS && op == XENMEM_get_vnumainfo )
> +        {
> +            cmp.vnuma.nr_vnodes = nat.vnuma->nr_vnodes;
> +            cmp.vnuma.nr_vcpus = nat.vnuma->nr_vcpus;
> +            cmp.vnuma.nr_vmemranges = nat.vnuma->nr_vmemranges;
> +            if ( __copy_to_guest(compat, &cmp.vnuma, 1) )
> +                rc = -EFAULT;
> +        }
>          if ( rc < 0 )
>              break;

Please move the new if() inside the body of the existing one.
Ack with that change.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel