Re: [Xen-devel] [PATCH v3 01/19] xen: dump vNUMA information with debug key "u"

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.01.15 at 13:11, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -408,6 +413,49 @@ static void dump_numa(unsigned char key)
>  
>          for_each_online_node ( i )
>              printk("    Node %u: %u\n", i, page_num_node[i]);
> +
> +        if ( !d->vnuma )
> +                continue;
> +
> +        vnuma = d->vnuma;

I'm sorry for noticing this only now, but don't you need to try to
acquire d->vnuma_rwlock for reading, and skip any printing if
the acquire attempt fails, to avoid a XEN_DOMCTL_setvnumainfo
invocation to make the information go away under your feet?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel