Re: [Xen-devel] [PATCH] libxl: provide xenlight.pc

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2015-01-13 at 12:56 +0000, Wei Liu wrote:
> On Tue, Jan 13, 2015 at 01:19:05PM +0100, Olaf Hering wrote:
> > On Tue, Jan 13, Ian Campbell wrote:
> > 
> > > On Fri, 2015-01-09 at 14:32 +0000, Wei Liu wrote:
> > > > A pkg-config file for libxl. It also contains two variables
> > > > (xenfirmwaredir and libexec_bin) so that tools that are very keen on
> > > > knowing the locations of Xen binaries (say, libvirt) can use them to
> > > > determine the location of the binaries.
> > > > 
> > > > Please rerun autogen.sh after applying this patch.
> > 
> > Forgot to reply to this earlier:
> > 
> > Should there really be another file.in.in.in.in mess? I think the
> > major/minor values could be placed into some m4 file so that they can be
> > substituted properly by configure.
> > 
> 
> I was two minded when I wrote this path. On one hand I didn't want to
> place a m4 file here, on the other I didn't want to leak library version
> numbers to top level m4 directory. Finally I decided to do the .in.in
> trick.
> 
> So if you have an argument for either of these please convince me...
> Or you have other idea about file placement please tell me.

I think the library SONAME belongs in the relevant Makefile, not hidden
in the m4 somewhere. Which I think necessitates .in.in. I think we can
live with that.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel