Re: [Xen-devel] Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.4, 4.5, and unstable

[Philipp Hahn <hahn@xxxxxxxxxxxxx>]

Hello,

On 12.01.2015 18:03, Ian Jackson wrote:
> Charles Arnold writes ("Re: Backport request for "tools/hotplug: set mtu from 
> bridge for tap interface" - for Xen 4.4, 4.5, and unstable"):
>> Add quotes around $bridge and $dev to handle spaces in names.
>> This should go into 4.4, 4.5 and unstable.
> 
> Is this really necessary for backporting ?
> 
> Frankly I think if you put spaces in your network device names an
> awful lot of things are going to break.

Luckily for you at least Linux does not allow space characters in
interface names: net/core/dev.c:936 dev_valid_name

On the other hand I find not caring about quoting somehow dangerous, as
I already expeienced one desaster caused by missing quotes. Just my 2¢.

Philipp

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel