Re: [Xen-devel] [PATCH v2 05/19] libxl: introduce vNUMA types

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2015-01-12 at 17:21 +0000, Wei Liu wrote:
> On Mon, Jan 12, 2015 at 05:17:24PM +0000, Ian Campbell wrote:
> > On Mon, 2014-12-01 at 15:33 +0000, Wei Liu wrote:
> > 
> > Looking ahead a few patches I see a disturbing trend to include little
> > or no commit message in this series. I also see no overview of what the
> > design for vnuma at the libxl level is going to look like, just a bunch
> > of moving parts in isolation, which are rather hard to review.
> > 
> > Please can you flesh out the descriptions of these patches, and maybe
> > take a look at the series structure. e.g. I'm not sure why the next
> > patch "libxl: add vmemrange to libxl__domain_build_state" needs to be
> > alone, instead of adding the struct field in the patch which adds
> > support for the field.
> > 
> 
> I will provide more information and resend.

Thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel