Re: [Xen-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 12 Jan 2015, Paolo Bonzini wrote:
> On 12/01/2015 14:35, Li, Liang Z wrote:
> > 
> > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c1bf357..f2893b2 100644
> > --- a/hw/xen/xen_pt.c
> > +++ b/hw/xen/xen_pt.c
> > @@ -736,7 +736,7 @@ static int xen_pt_initfn(PCIDevice *d)
> >      }
> >  
> >  out:
> > -    memory_listener_register(&s->memory_listener, &address_space_memory);
> > +    memory_listener_register(&s->memory_listener, 
> > + &s->dev.bus_master_as);
> >      memory_listener_register(&s->io_listener, &address_space_io);
> >      XEN_PT_LOG(d,
> >                 "Real physical device %02x:%02x.%d registered 
> > successfully!\n",
> > 
> > By further debugging, I found when using 'address_space_memory',  
> > 'xen_pt_region_del' 
> > won't be called when the memory region's name is not  ' xen-pci-pt-*', when 
> > using
> >  ' s->dev.bus_master_as ', there is no such issue.
> > 
> > I think use the device related address space here is more reasonable, but I 
> > am not sure.
> >  Could you give some suggestion?
> 
> Yes, this patch makes sense.  The listener will be called every time the
> command register is written.

Paolo, thanks for reviewing!

Liang, please resend with an appropriate patch description and
sign-off-by line.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel