Re: [Xen-devel] [PATCH v2 1/3] x86: also allow REP STOS emulation acceleration

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Fri, Jan 9, 2015 at 12:10 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 09.01.15 at 12:45, <tim@xxxxxxx> wrote:
>> At 11:24 +0000 on 09 Jan (1420799087), Jan Beulich wrote:
>>> >>> On 09.01.15 at 12:18, <tim@xxxxxxx> wrote:
>>> >> > +            default:
>>> >> > +                xfree(buf);
>>> >> > +                ASSERT(!buf);
>>> >
>>> > looks dodgy...
>>>
>>> In which way? The "default" is supposed to be unreachable, and sits
>>> in the else branch to an if(!buf), i.e. in a release build we'll correctly
>>> free the buffer, while in a debug build the ASSERT() will trigger.
>>
>> Oh I see.  Can you please use ASSERT(0) for that?
>
> I sincerely dislike ASSERT(0), but if that's the only way to get
> the patch accepted...

Um, by what set of criteria is ASSERT(!buf) better than ASSERT(0)?  At
least the second tells the reader that you're not using ASSERT() the
normal way.

I agree that ASSERT_UNREACHABLE() is probably the best option.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel