Re: [Xen-devel] xen-ringwatch issues

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2015-01-09 at 17:00 -0500, moftah moftah wrote:
> Hi Ian,
> 
> 
> OK, I have followed your suggestions and created a new patch

Thanks, please submit it in the form describe in the wiki page
http://wiki.xen.org/wiki/Submitting_Xen_Patches which I referenced
before.

In particular, a Signed-off-by is a strict requirement for licensing
reasons, to indicate that you have read the DCO (which is at
http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch ).

Please also provide a suitable changelog entry and use a unified diff
(diff -u).

I think rather than "[-]*" the right addition would be -? (i.e. a single
optional negative sign), unless Python's re syntax is lots different to
what I expect.

> this new patch does fix the issue fully for the negative numbers
>
> I didnt run the patch on 64bit OS since xenserver has 32bit Dom0

These fields are unsigned int, .i.e. always 32-bits. So I think your "if
self.conf < 0: self.cons = 4294967296 + self.cons" etc will work. The
Internet also suggests "ctypes.c_uint32(i).value", dunno if that is
better. In any case writing 4294967296 as 2**32 would be slightly
clearer.

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel